Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: method to add notes on design #5271

Merged
merged 8 commits into from
Oct 11, 2024
Merged

FEAT: method to add notes on design #5271

merged 8 commits into from
Oct 11, 2024

Conversation

anur7
Copy link
Contributor

@anur7 anur7 commented Oct 9, 2024

No description provided.

@anur7 anur7 added the enhancement New features or code improvements label Oct 9, 2024
@anur7 anur7 self-assigned this Oct 9, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@anur7 anur7 linked an issue Oct 9, 2024 that may be closed by this pull request
@anur7 anur7 marked this pull request as ready for review October 9, 2024 15:16
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (4e783b5) to head (e01cee8).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5271      +/-   ##
==========================================
- Coverage   83.26%   83.26%   -0.01%     
==========================================
  Files         143      143              
  Lines       58464    58471       +7     
==========================================
+ Hits        48679    48684       +5     
- Misses       9785     9787       +2     

SMoraisAnsys
SMoraisAnsys previously approved these changes Oct 10, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment.

src/ansys/aedt/core/application/design.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/application/design.py Show resolved Hide resolved
src/ansys/aedt/core/application/design.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/application/design.py Show resolved Hide resolved
anur7 and others added 2 commits October 10, 2024 10:43
Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@gmalinve gmalinve mentioned this pull request Oct 10, 2024
@gmalinve gmalinve linked an issue Oct 10, 2024 that may be closed by this pull request
Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anur7 anur7 merged commit 3841993 into main Oct 11, 2024
42 checks passed
@anur7 anur7 deleted the feat/Design_edit_note branch October 11, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add design notes Add EditNotes function to pyAEDT
3 participants